‘London is on the Thames’ is correct as a statement of fact.

Some towns which are on the Thames refer to themselves as ‘on-Thames’ or ‘upon-Thames’. Staines for example recently renamed itself, ‘Staines-upon-Thames’.

Many towns on other rivers in the country are named in a similar fashion, Newcastle upon Tyne’, for example.